zigbee2mqtt test is disabled here. Couldn't we enable it back?

zigbee2mqtt test is disabled here. Couldn't we enable it back?

Yep!, I just forgot to after we merged the fix. I'll do that now.

@mstormi I can't quite fathom why, but OpenJDK 21 really doesn't like the GitHub Actions env. When I run it locally on Docker it works perfectly but not in Actions. I feel confident enough with all of this for it to be reviewed though.

I'm on the fence about defaulting to the Temurin over OpenJDK for 21 because of the issues I'm seeing here and because then it has to use unstable for the source. It also upgrades other packages when installing from unstable because they are dependencies which I don't really like (ie libc6). Temurin is also now the most widely supported JVM in general that Oracle doesn't build reference implementations anyways.

Let me know your thoughts.

(There ended up being a bunch of random fixes to automated testing that I found and added while debugging that stupid OpenJDK 21 issue that I never could figure out)

LGTM overall although I'm unable to determine by just looking at the diffs if OpenJDK 21 is really available now and where it's coming from.

The firmware comments at the end are guessed but you probably wrote that code before you saw I revoked your recent changes.

Yeah I'll fix those. OpenJDK 21 is available from unstable and Temurin. Both are provided as options and should work well.

Alright. I think you should release a new image with this in, plus the fixed hotspot.
Don't forget to forward main to openHAB branch.

Should I make it another patch release or do a minor to 1.10? I'm thinking 1.10 because of the addition of Java 21 support.

WDYT?

yeah, 1.10. Went for beer (alcfree) and wanted to add that but you were faster :)

pls also add the changelog like in older releases, too.
(got word that the hotspot still doesn't do but it's bedtime for me today)